Skip to content

[pull] main from Xedon:main#2

Open
pull[bot] wants to merge 12 commits intolecodeski:mainfrom
Xedon:main
Open

[pull] main from Xedon:main#2
pull[bot] wants to merge 12 commits intolecodeski:mainfrom
Xedon:main

Conversation

@pull
Copy link

@pull pull bot commented Apr 7, 2023

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

@pull pull bot added ⤵️ automatic pull merge-conflict Resolve conflicts manually labels Apr 7, 2023
@pull pull bot requested a review from lecodeski April 7, 2023 17:26
Xedon and others added 10 commits April 10, 2023 10:22
In multithreaded (or async) contexts, using RefCell (as in
Arc<RefCell<T>>) might cause panics if multiple borrows are
accessed, since RefCell is meant for single-threaded use,
which is why Clippy was complaining when holding a RefCell
borrow across await points.

The thread-safe alternative to RefCell is either Mutex or RwLock,
while the latter is better in read-heavy contexts, hence this change.
* refactor: typo

* refactor: remove unnecessary imports

* refactor: avoid Result wrapping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⤵️ automatic pull merge-conflict Resolve conflicts manually

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants